fix: use 'close' event for seed process and deduplicate buildPerfServerEnv

- Change once(seedProcess, 'exit') to once(seedProcess, 'close') in
  appHarness.ts and open-perf-app.ts to ensure piped stdio buffers are
  fully drained before parsing stdout.

- Extract buildPerfServerEnv into @t3tools/shared/perf/serverEnv to
  eliminate identical copies in serverPerfHarness.ts and web serverEnv.ts.
  Both consumers now import from the shared module.

Author: cursoragent

apps/server/integration/perf/serverPerfHarness.ts

@@ -33,13 +33,11 @@ import type {
   PerfProviderScenarioId,
   PerfSeedScenarioId,
 } from "@t3tools/shared/perf/scenarioCatalog";
+import { buildPerfServerEnv } from "@t3tools/shared/perf/serverEnv";
 import { seedPerfState, type PerfSeededState } from "./seedPerfState.ts";
 
 const repoRoot = fileURLToPath(new URL("../../../../", import.meta.url));
 const PERF_ARTIFACT_DIR_ENV = "T3CODE_PERF_ARTIFACT_DIR";
-const PERF_PROVIDER_ENV = "T3CODE_PERF_PROVIDER";
-const PERF_SCENARIO_ENV = "T3CODE_PERF_SCENARIO";
-const AUTO_BOOTSTRAP_PROJECT_ENV = "T3CODE_AUTO_BOOTSTRAP_PROJECT_FROM_CWD";
 
 const makeWsRpcClient = RpcClient.make(WsRpcGroup);
 type WsRpcClient =
@@ -184,28 +182,6 @@ async function writeServerLogs(
   ]);
 }
 
-function buildPerfServerEnv(
-  baseEnv: NodeJS.ProcessEnv,
-  providerScenarioId?: PerfProviderScenarioId,
-): NodeJS.ProcessEnv {
-  const env: NodeJS.ProcessEnv = {
-    ...baseEnv,
-    [AUTO_BOOTSTRAP_PROJECT_ENV]: "false",
-  };
-
-  if (!providerScenarioId) {
-    delete env[PERF_PROVIDER_ENV];
-    delete env[PERF_SCENARIO_ENV];
-    return env;
-  }
-
-  return {
-    ...env,
-    [PERF_PROVIDER_ENV]: "1",
-    [PERF_SCENARIO_ENV]: providerScenarioId,
-  };
-}
-
 export class PerfWsRpcClient {
   private readonly runtime: ManagedRuntime.ManagedRuntime<RpcClient.Protocol, never>;
   private readonly clientScope: Scope.Closeable;

apps/web/test/perf/appHarness.ts

@@ -266,7 +266,7 @@ export async function startPerfAppHarness(
     seedProcess.stderr?.on("data", (chunk) => {
       stderr += chunk.toString();
     });
-    const [exitCode] = (await once(seedProcess, "exit")) as [number | null];
+    const [exitCode] = (await once(seedProcess, "close")) as [number | null];
     if (exitCode !== 0) {
       throw new Error(`Perf seed command failed with code ${exitCode ?? "unknown"}.\n${stderr}`);
     }

apps/web/test/perf/serverEnv.ts

@@ -1,27 +1,5 @@
-import type { PerfProviderScenarioId } from "@t3tools/shared/perf/scenarioCatalog";
-
-export const PERF_PROVIDER_ENV = "T3CODE_PERF_PROVIDER";
-export const PERF_SCENARIO_ENV = "T3CODE_PERF_SCENARIO";
-const AUTO_BOOTSTRAP_PROJECT_ENV = "T3CODE_AUTO_BOOTSTRAP_PROJECT_FROM_CWD";
-
-export function buildPerfServerEnv(
-  baseEnv: NodeJS.ProcessEnv,
-  providerScenarioId?: PerfProviderScenarioId,
-): NodeJS.ProcessEnv {
-  const env: NodeJS.ProcessEnv = {
-    ...baseEnv,
-    [AUTO_BOOTSTRAP_PROJECT_ENV]: "false",
-  };
-
-  if (!providerScenarioId) {
-    delete env[PERF_PROVIDER_ENV];
-    delete env[PERF_SCENARIO_ENV];
-    return env;
-  }
-
-  return {
-    ...env,
-    [PERF_PROVIDER_ENV]: "1",
-    [PERF_SCENARIO_ENV]: providerScenarioId,
-  };
-}
+export {
+  buildPerfServerEnv,
+  PERF_PROVIDER_ENV,
+  PERF_SCENARIO_ENV,
+} from "@t3tools/shared/perf/serverEnv";

packages/shared/package.json

@@ -51,6 +51,10 @@
     "./perf/artifact": {
       "types": "./src/perf/artifact.ts",
       "import": "./src/perf/artifact.ts"
+    },
+    "./perf/serverEnv": {
+      "types": "./src/perf/serverEnv.ts",
+      "import": "./src/perf/serverEnv.ts"
     }
   },
   "scripts": {

packages/shared/src/perf/serverEnv.ts

@@ -0,0 +1,27 @@
+import type { PerfProviderScenarioId } from "./scenarioCatalog.ts";
+
+export const PERF_PROVIDER_ENV = "T3CODE_PERF_PROVIDER";
+export const PERF_SCENARIO_ENV = "T3CODE_PERF_SCENARIO";
+const AUTO_BOOTSTRAP_PROJECT_ENV = "T3CODE_AUTO_BOOTSTRAP_PROJECT_FROM_CWD";
+
+export function buildPerfServerEnv(
+  baseEnv: NodeJS.ProcessEnv,
+  providerScenarioId?: PerfProviderScenarioId,
+): NodeJS.ProcessEnv {
+  const env: NodeJS.ProcessEnv = {
+    ...baseEnv,
+    [AUTO_BOOTSTRAP_PROJECT_ENV]: "false",
+  };
+
+  if (!providerScenarioId) {
+    delete env[PERF_PROVIDER_ENV];
+    delete env[PERF_SCENARIO_ENV];
+    return env;
+  }
+
+  return {
+    ...env,
+    [PERF_PROVIDER_ENV]: "1",
+    [PERF_SCENARIO_ENV]: providerScenarioId,
+  };
+}

scripts/open-perf-app.ts

@@ -208,7 +208,7 @@ async function seedPerfState(scenarioId: PerfSeedScenarioId): Promise<PerfSeeded
     stderr += chunk.toString();
   });
 
-  const [exitCode] = (await once(seedProcess, "exit")) as [number | null];
+  const [exitCode] = (await once(seedProcess, "close")) as [number | null];
   if (exitCode !== 0) {
     throw new Error(`Perf seed command failed with code ${exitCode ?? "unknown"}.\n${stderr}`);
   }