Skip to content

Commit e5394e0

Browse files
committed
fix: set desktopState.backendReady to true in onReady callback
The onReady callback updated the internal manager state's ready field but never set desktopState.backendReady to true. The ref was only ever set to false (on start, finalize, and stop), so any consumer reading desktopState.backendReady would always see false even after the backend was confirmed ready via HTTP. Also removed the manual workaround in the test that set backendReady to true externally.
1 parent 413d2f9 commit e5394e0

2 files changed

Lines changed: 1 addition & 1 deletion

File tree

apps/desktop/src/backend/DesktopBackendManager.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,6 @@ describe("DesktopBackendManager", () => {
328328
yield* manager.start;
329329
assert.equal(yield* Queue.take(startedPids), 123);
330330
yield* Deferred.await(ready);
331-
yield* Ref.set(backendReady, true);
332331
assert.isTrue(yield* Ref.get(backendReady));
333332
assert.deepEqual(yield* manager.currentConfig, Option.some(baseConfig));
334333

apps/desktop/src/backend/DesktopBackendManager.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -443,6 +443,7 @@ const makeDesktopBackendManager = Effect.fn("makeDesktopBackendManager")(functio
443443
onSome: (run) => (run.id === runId ? true : latest.ready),
444444
}),
445445
}));
446+
yield* Ref.set(desktopState.backendReady, true);
446447
yield* desktopWindow.handleBackendReady.pipe(
447448
Effect.catch((error) =>
448449
Effect.logError("failed to open main window after backend readiness").pipe(

0 commit comments

Comments
 (0)