Fix Bitbucket API: send explicit state params for 'all' and remove dead code

- Fix toBitbucketState returning null for 'all', which caused the
  Bitbucket REST API to default to returning only OPEN pull requests.
  Changed to toBitbucketStates returning an array, and use
  appendUrlParam to send OPEN, MERGED, DECLINED, and SUPERSEDED
  state params when listing all pull requests.

- Remove unused exported functions (decodeBitbucketPullRequestListJson,
  decodeBitbucketPullRequestJson, formatBitbucketJsonDecodeError) and
  their internal helpers from bitbucketPullRequests.ts, along with
  now-unused imports.

Author: cursoragent

apps/server/src/sourceControl/BitbucketApi.ts

@@ -162,16 +162,16 @@ function sourceWorkspace(input: {
   return ownerSelector?.[1]?.trim();
 }
 
-function toBitbucketState(state: "open" | "closed" | "merged" | "all"): string | null {
+function toBitbucketStates(state: "open" | "closed" | "merged" | "all"): ReadonlyArray<string> {
   switch (state) {
     case "open":
-      return "OPEN";
+      return ["OPEN"];
     case "closed":
-      return "DECLINED";
+      return ["DECLINED"];
     case "merged":
-      return "MERGED";
+      return ["MERGED"];
     case "all":
-      return null;
+      return ["OPEN", "MERGED", "DECLINED", "SUPERSEDED"];
   }
 }
 
@@ -405,26 +405,24 @@ export const make = Effect.fn("makeBitbucketApi")(function* () {
     listPullRequests: (input) =>
       resolveRepository(input).pipe(
         Effect.flatMap((repository) => {
-          const state = toBitbucketState(input.state);
+          const states = toBitbucketStates(input.state);
           const query: Record<string, string> = {
             pagelen: String(Math.max(1, Math.min(input.limit ?? 20, 50))),
             sort: "-updated_on",
             q: `source.branch.name = "${sourceBranch(input).replaceAll('"', '\\"')}"`,
           };
-          if (state !== null) {
-            query.state = state;
-          }
 
-          return executeJson(
-            "listPullRequests",
-            HttpClientRequest.get(
-              apiUrl(
-                `/repositories/${encodeURIComponent(repository.workspace)}/${encodeURIComponent(repository.repoSlug)}/pullrequests`,
-              ),
-              { urlParams: query },
+          let request = HttpClientRequest.get(
+            apiUrl(
+              `/repositories/${encodeURIComponent(repository.workspace)}/${encodeURIComponent(repository.repoSlug)}/pullrequests`,
             ),
-            BitbucketPullRequestListSchema,
+            { urlParams: query },
           );
+          for (const s of states) {
+            request = HttpClientRequest.appendUrlParam(request, "state", s);
+          }
+
+          return executeJson("listPullRequests", request, BitbucketPullRequestListSchema);
         }),
         Effect.map((list) => list.values.map(normalizeBitbucketPullRequestRecord)),
       ),

apps/server/src/sourceControl/bitbucketPullRequests.ts

@@ -1,6 +1,5 @@
-import { Cause, DateTime, Exit, Option, Result, Schema } from "effect";
+import { DateTime, Option, Schema } from "effect";
 import { PositiveInt, TrimmedNonEmptyString } from "@t3tools/contracts";
-import { decodeJsonResult, formatSchemaError } from "@t3tools/shared/schemaJson";
 
 export interface NormalizedBitbucketPullRequestRecord {
   readonly number: number;
@@ -103,49 +102,3 @@ export function normalizeBitbucketPullRequestRecord(
     ...(headRepositoryOwnerLogin ? { headRepositoryOwnerLogin } : {}),
   };
 }
-
-const decodeBitbucketPullRequestList = decodeJsonResult(Schema.Unknown);
-const decodeBitbucketPullRequest = decodeJsonResult(BitbucketPullRequestSchema);
-const decodeBitbucketPullRequestEntry = Schema.decodeUnknownExit(BitbucketPullRequestSchema);
-
-export const formatBitbucketJsonDecodeError = formatSchemaError;
-
-export function decodeBitbucketPullRequestListJson(
-  raw: string,
-): Result.Result<
-  ReadonlyArray<NormalizedBitbucketPullRequestRecord>,
-  Cause.Cause<Schema.SchemaError>
-> {
-  const result = decodeBitbucketPullRequestList(raw);
-  if (Result.isFailure(result)) {
-    return Result.fail(result.failure);
-  }
-
-  const entries: ReadonlyArray<unknown> = Array.isArray(result.success)
-    ? result.success
-    : typeof result.success === "object" &&
-        result.success !== null &&
-        "values" in result.success &&
-        Array.isArray(result.success.values)
-      ? result.success.values
-      : [];
-  const pullRequests: NormalizedBitbucketPullRequestRecord[] = [];
-  for (const entry of entries) {
-    const decodedEntry = decodeBitbucketPullRequestEntry(entry);
-    if (Exit.isFailure(decodedEntry)) {
-      continue;
-    }
-    pullRequests.push(normalizeBitbucketPullRequestRecord(decodedEntry.value));
-  }
-  return Result.succeed(pullRequests);
-}
-
-export function decodeBitbucketPullRequestJson(
-  raw: string,
-): Result.Result<NormalizedBitbucketPullRequestRecord, Cause.Cause<Schema.SchemaError>> {
-  const result = decodeBitbucketPullRequest(raw);
-  if (Result.isSuccess(result)) {
-    return Result.succeed(normalizeBitbucketPullRequestRecord(result.success));
-  }
-  return Result.fail(result.failure);
-}