Skip to content

Conversation

@Sean-Der
Copy link
Member

SampleBuilder now respects maxLate after a buffer have been popped

Copy link
Contributor

@maxhawkins maxhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Feb 15, 2019

Pull Request Test Coverage Report for Build 2011

  • 13 of 15 (86.67%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 79.236%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/media/samplebuilder/samplebuilder.go 13 15 86.67%
Files with Coverage Reduction New Missed Lines %
rtcdtlstransport.go 4 75.14%
Totals Coverage Status
Change from base Build 2007: -0.08%
Covered Lines: 3900
Relevant Lines: 4922

💛 - Coveralls

SampleBuilder now respects maxLate after a buffer have been popped
@Sean-Der Sean-Der merged commit 5efb6b0 into master Feb 15, 2019
@Sean-Der Sean-Der removed the review label Feb 15, 2019
@Sean-Der Sean-Der deleted the sample-builder branch February 18, 2019 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants