Skip to content

Update version for codegen container#6717

Open
khanhtc1202 wants to merge 1 commit intomasterfrom
update-go-version-for-codegen-container
Open

Update version for codegen container#6717
khanhtc1202 wants to merge 1 commit intomasterfrom
update-go-version-for-codegen-container

Conversation

@khanhtc1202
Copy link
Copy Markdown
Member

What this PR does:

part of updating go version for pipecd to v1.26.2

Why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202 khanhtc1202 requested a review from a team as a code owner April 27, 2026 08:34
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.51%. Comparing base (fdec720) to head (b9095cf).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6717      +/-   ##
==========================================
+ Coverage   29.48%   29.51%   +0.03%     
==========================================
  Files         593      592       -1     
  Lines       63440    63357      -83     
==========================================
- Hits        18706    18702       -4     
+ Misses      43289    43209      -80     
- Partials     1445     1446       +1     
Flag Coverage Δ
. 23.29% <ø> (ø)
.-pkg-app-pipedv1-plugin-analysis 32.43% <ø> (ø)
.-pkg-app-pipedv1-plugin-ecs 31.82% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 58.37% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 61.90% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 37.95% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 33.04% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 52.71% <ø> (ø)
.-pkg-plugin-sdk 50.14% <ø> (-0.20%) ⬇️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.51% <ø> (ø)
.-tool-codegen-protoc-gen-auth ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khanhtc1202
Copy link
Copy Markdown
Member Author

I found an issue in this rabbit hole :(

  • go version update requires code/gen to be passed
  • code/gen go version update requires lint to be passed
  • lint to be passed relies on list-go-modules step in the lint workflow, which lists all go modules in pipecd repo (no ignore)

Should we temporarily mark the lint/go workflow as not required in order to update go version for modules first, then re-enable it later? cc @Warashi @mohammedfirdouss

@mohammedfirdouss
Copy link
Copy Markdown
Contributor

Should we temporarily mark the lint/go workflow as not required in order to update go version for modules first, then re-enable it later? cc @Warashi @mohammedfirdouss

Yes this is fine @khanhtc1202 as long as we have a single tracking PR that lists all affected modules and re-enabling lint is the last step before closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants