Rewrote preprocessor importer to comply with new Dart Sass #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
LGTM, thank you for looking into it and sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the importer in your Sass preprocessOptions compatible with the new compileString() API (introduced in Dart Sass v1.56.0), you need to adjust the format of the importer to follow the new Importer API, which has changed how custom importers work.
In this PR I have rewritten the preprocessor importer to comply with the new compileString API. Tested locally and it now works with newer Vue-versions which was the original issue reported here: #30. (Current version of this package does not work with newer versions of vue or @vue/compiler-sfc > 3.5.11)