Swap sockjs-client-node with sockjs-client #17
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
|
We're planning to invest into adding proper unit tests to the client library but for now I manually went through most of the functionality that might be affected by this change and it is working as expected. Merging this in. Thank you for the pull request! |
martintajur
added a commit
that referenced
this pull request
Nov 5, 2015
Swap sockjs-client-node with sockjs-client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swapping to sockjs-client allows package to work with recent versions of Node (4.x), though I'm unsure if it has any impact on older versions (untested). Anyway, sockjs-client-node is deprecated.