Skip to content

Conversation

@kashmircake
Copy link
Contributor

There was a vulnerability with url-parse, which is used by sockjs-client.
Vulnerability is fixed, tests are passing.

@kashmircake kashmircake requested a review from a team December 18, 2018 15:02
@kashmircake kashmircake self-assigned this Dec 18, 2018
@DenisButCheR
Copy link
Contributor

DenisButCheR commented Feb 4, 2019

It looks like GitHub wants to have version 1.4.3 or newer. https://github.com/pipedrive/client-nodejs/network/alert/package-lock.json/url-parse/open

Check please!

@DenisButCheR DenisButCheR self-requested a review February 5, 2019 08:29
@kashmircake kashmircake merged commit 96f6f35 into master Feb 5, 2019
@ziimk ziimk deleted the url-parse-security-fix branch February 5, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants