Do not use table alias, this way we reuse existing joins #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
force-pushed
the
notablealias
branch
2 times, most recently
from
b2533fa to
717dd7f
Compare
tsteur
added a commit
that referenced
this pull request
Dec 7, 2015
Do not use table alias, this way we reuse existing joins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can only merge this one after PR matomo-org/matomo#9314 was merged and after a new beta was released. Then we need to require the new Piwik beta version in plugin.json and .travis.yml and see if it still works before merging this PR.
Not using an alias will make the query/archiving faster as we can reuse existing joins used by core this way