pkp/pkp-lib#11826 Integrate type, description, due interval when saving templates #723
Conversation
jardakotesovec
left a comment
jardakotesovec
left a comment
There was a problem hiding this comment.
This looks good, main question is whether we could use FieldPreparedContent instead of FieldRichTextArea to have good reuse with what we have in the form for editing/adding mail templates.
| userGroupsApiUrl, | ||
| { | ||
| page: 1, | ||
| pageSize: 50, |
There was a problem hiding this comment.
We for sure want to fetch all of them, right? 50 should be enough. But to be super safe lets go with 1000 or something like that :-)
| {label: 'Section Editor', value: pkp.const.ROLE_ID_SUB_EDITOR}, | ||
| ]; | ||
| const {apiUrl: userGroupsApiUrl} = useUrl( | ||
| `contexts/${pkp.context.id}/userGroups`, |
There was a problem hiding this comment.
I suggested to Vitaliy on mattermost to move this outside of the context.. so this url might move, lets see how the discussion evolves.
| text: t('common.insertContent'), | ||
| onAction() { | ||
| const {openSideModal} = useModal(FieldPreparedContentInsertModal); | ||
| const {openSideModal, closeSideModal} = useModal( |
There was a problem hiding this comment.
Would be possible to use the FieldPreparedContent as its used in form for adding/editing email templates? Seems that we are duplicating some logic from that.
…ent as field in the form
…eTaskTemplateManagerStore
…dy payload when adding a new task template
…in TableColumn component
…TextArea on description field
blesildaramirez
force-pushed
the
i11826
branch
from
17adfd3 to
5733d3d
Compare
blesildaramirez
force-pushed
the
i11826
branch
from
d3ec908 to
8cbdd28
Compare
2 participants
No description provided.