Skip to content

pkp/pkp-lib#11826 Update column name and remove Attach File in discussion textarea #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

pkp/pkp-lib#11826 Update column name and remove Attach File in discussion textarea #742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeb7eca
pkp/pkp-lib#11826 Change column names for task templates
blesildaramirez Nov 11, 2025
9702683
pkp/pkp-lib#11826 Remove Attach File when creating task templates
blesildaramirez Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion public/globals.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1113,9 +1113,10 @@ window.pkp = {
'taskTemplates.edit': 'Edit Task and Discussion Template',
'taskTemplates.templateAutoAdd':
'Automatically add this task and discussion when a submission reaches a specific stage',
'taskTemplates.templateAutoAddAtStage': 'Auto-add at stage',
'taskTemplates.templateAutoAddInStage':
'Automatically add this task and/or discussion when a submission reaches the stage',
'taskTemplates.templateName': 'Task and discussion template name',
'taskTemplates.templateName': 'Template name',
'taskTemplates.title': 'Tasks and Discussions Templates',
'user.affiliation': 'Affiliation',
'user.affiliations': 'Affiliations',
Expand Down
2 changes: 1 addition & 1 deletion src/managers/TaskTemplateManager/useTaskTemplateManagerConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export function useTaskTemplateManagerConfig() {
});

columns.push({
header: t('taskTemplates.templateAutoAdd'),
header: t('taskTemplates.templateAutoAddAtStage'),
component: 'TaskTemplateManagerCellAutoAdd',
});

Expand Down
26 changes: 1 addition & 25 deletions src/managers/TaskTemplateManager/useTaskTemplateManagerForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,8 @@ import {useFetch} from '@/composables/useFetch';
import {useFetchPaginated} from '@/composables/useFetchPaginated';
import {useFormChanged} from '@/composables/useFormChanged';
import {useLocalize} from '@/composables/useLocalize';
import {useModal} from '@/composables/useModal';
import {useTaskTemplateManagerEmails} from './useTaskTemplateManagerEmails';

import FileAttacherModal from '@/components/Composer/FileAttacherModal.vue';

export function useTaskTemplateManagerForm({
taskTemplate = null,
stage = null,
Expand Down Expand Up @@ -163,26 +160,6 @@ export function useTaskTemplateManagerForm({
];
}

function initDiscussionText() {
return {
setup: (editor) => {
editor.ui.registry.addButton('pkpAttachFiles', {
icon: 'upload',
text: t('common.attachFiles'),
onAction() {
const {openSideModal} = useModal();

openSideModal(FileAttacherModal, {
title: t('common.attachFiles'),
attachers: [],
onAddAttachments: [],
});
},
});
},
};
}

const preparedContent = computed(() => {
const dataDescriptions = emailTemplatesData.value?.dataDescriptions;
if (!dataDescriptions) {
Expand Down Expand Up @@ -269,10 +246,9 @@ export function useTaskTemplateManagerForm({

addFieldPreparedContent('description', {
groupId: 'discussion',
toolbar: 'bold italic underline bullist | pkpAttachFiles | pkpInsert',
toolbar: 'bold italic underline bullist | pkpInsert',
plugins: ['lists'],
size: 'large',
init: initDiscussionText(),
value: taskTemplate?.description || '',
insertModalLabel: t('common.insertContent'),
insertLabel: t('common.insert'),
Expand Down