Skip to content

Optimize Plack::Response->finalize#433

Merged
miyagawa merged 1 commit intoplack:masterfrom
kazeburo:master
Oct 22, 2013
Merged

Optimize Plack::Response->finalize#433
miyagawa merged 1 commit intoplack:masterfrom
kazeburo:master

Conversation

@kazeburo
Copy link
Copy Markdown
Contributor

  • use HTTP::Headers->scan to build a headers arrray
  • pass this array to _finalize_cookie
  • HTTP::Headers->clone becomes unnecessary

This patch makes 2x faster for finalize response.
benchmark code is here. https://gist.github.com/kazeburo/7093522

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.04%) when pulling 14eabe2 on kazeburo:master into 8ec3140 on plack:master.

@tokuhirom
Copy link
Copy Markdown
Member

+1

miyagawa added a commit that referenced this pull request Oct 22, 2013
Optimize Plack::Response->finalize
@miyagawa miyagawa merged commit f168ddc into plack:master Oct 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants