Allow passing custom formatters to Plack::Middleware::AccessLog#515
Merged
miyagawa merged 1 commit intoplack:masterfrom Nov 20, 2015
frioux:custom-formatters
Merged
Allow passing custom formatters to Plack::Middleware::AccessLog#515miyagawa merged 1 commit intoplack:masterfrom frioux:custom-formatters
miyagawa merged 1 commit intoplack:masterfrom
frioux:custom-formatters
Conversation
Member
|
I would make |
Member
|
Other than that it looks pretty trivial and good. |
Contributor
Author
|
I'll change it; if anyone's taste should I would think you would be that person. |
Contributor
Author
|
done |
Member
|
Thanks. cc @kazeburo |
Member
|
@kazeburo any thoughts on this change? |
Contributor
|
👍 |
miyagawa
added a commit
that referenced
this pull request
Nov 20, 2015
Allow passing custom formatters to Plack::Middleware::AccessLog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.