Skip to content

Do not set if TCP_NODELAY is not available#579

Merged
miyagawa merged 2 commits intoplack:masterfrom
dex4er:bugfix_android_tcp_nodelay
Feb 10, 2018
Merged

Do not set if TCP_NODELAY is not available#579
miyagawa merged 2 commits intoplack:masterfrom
dex4er:bugfix_android_tcp_nodelay

Conversation

@dex4er
Copy link
Copy Markdown
Contributor

@dex4er dex4er commented Oct 29, 2016

Hi,

On Android with Termux and Perl 5.24.0:

u0_a168@localhost:~$ perl -MSocket=TCP_NODELAY -e TCP_NODELAY
Your vendor has not defined Socket macro TCP_NODELAY, used at -e line 1

Could you add some workaround, please?

@miyagawa
Copy link
Copy Markdown
Member

miyagawa commented Nov 7, 2016

You should not call eval in every request - instead you should do it once when importing Socket module and define it as a constant in the package.

@miyagawa miyagawa merged commit ce77a4c into plack:master Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants