protect WrapCGI against SIGCHLD handlers#596
Merged
miyagawa merged 1 commit intoplack:masterfrom Jul 24, 2017
dakkar:protect-against-sigchld-handlers
Merged
protect WrapCGI against SIGCHLD handlers#596miyagawa merged 1 commit intoplack:masterfrom dakkar:protect-against-sigchld-handlers
miyagawa merged 1 commit intoplack:masterfrom
dakkar:protect-against-sigchld-handlers
Conversation
If `$SIG{CHLD}` is set to `'IGNORE'`, or to a "reaper" coderef,
`WrapCGI` (in "execute" mode) stalls in a tight loop when the CGI
exits, because `waitpid` returns -1 instead of the positive pid it
would usually return.
This patch fixes that (and tests that it works)
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
$SIG{CHLD}is set to'IGNORE', or to a "reaper" coderef,WrapCGI(in "execute" mode) stalls in a tight loop when the CGI exits, becausewaitpidreturns -1 instead of the positive pid it would usually return.This patch fixes that (and tests that it works)