Restrict Plack::App::File request methods, GH#660#662
Merged
miyagawa merged 1 commit intoplack:masterfrom Feb 15, 2021
Merged
Conversation
Static file requests (handled by Plack::App::File, which is used by Plack::Middleware::Static) were allowing any request method, including POST or DELETE. This change only allows GET and HEAD requests. Other requests will receive a HTTP 405 error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static file requests (handled by Plack::App::File, which is used
by Plack::Middleware::Static) were allowing any request method,
including POST or DELETE.
This change only allows GET and HEAD requests. Other requests
will receive a HTTP 405 error.
Fixes #660.