refactor: idiomatic express w/ built-in express error and async handling #285
+312
−321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolaj86
force-pushed
the
idiomatic-express-js
branch
2 times, most recently
from
a8aa99d to
8e2b0b4
Compare
coolaj86
force-pushed
the
idiomatic-express-js
branch
from
8e2b0b4 to
219b126
Compare
coolaj86
changed the title
lindawoo-plaid
approved these changes
Dec 9, 2021
Contributor
|
thank you @coolaj86 |
SpencerHHurst
pushed a commit
to SpencerHHurst/quickstart
that referenced
this pull request
Jul 10, 2024
…ing (plaid#285) * feature: use built-in express error handling * refactor: remove redundant resolve indirection Co-authored-by: lindawoo-plaid <77688518+lindawoo-plaid@users.noreply.github.com>
fisherrjd
pushed a commit
to fisherrjd/quickstart
that referenced
this pull request
Oct 12, 2024
…ing (plaid#285) * feature: use built-in express error handling * refactor: remove redundant resolve indirection Co-authored-by: lindawoo-plaid <77688518+lindawoo-plaid@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExpressJS has built-in error handling.
This uses that (via
.catch(next)), rather that duplicating error handling logic throughout.Also
.catchfor clean, easy-to-read async error handling)returns that may be confusing to the reader (nothing is actually returned)'use strict';(unlike front-end code which is transpiled, node code must explicitly set'use strict';, otherwise errors may not be caught properly)npx prettier@2.x -w index.jswith existing .prettierrc, which caused some whitespace changes.prettierrc?)Preview
Best viewed with whitespace changes ignored:
https://github.com/plaid/quickstart/pull/285/files?diff=unified&w=1