[LP-633] fixing country codes issue for Java #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial attempt
phoenixy1
approved these changes
Apr 18, 2022
Contributor
phoenixy1
left a comment
phoenixy1
left a comment
There was a problem hiding this comment.
Assuming you ran this and it works, this looks fine. Thanks!
Contributor
Author
yes I ran this locally and it worked |
SpencerHHurst
pushed a commit
to SpencerHHurst/quickstart
that referenced
this pull request
Jul 10, 2024
[LP-633] fixing country codes issue for Java
fisherrjd
pushed a commit
to fisherrjd/quickstart
that referenced
this pull request
Oct 12, 2024
[LP-633] fixing country codes issue for Java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA here. We currently hard code the country codes in the java quickstart folder. This PR pulls the correct country codes form the .env file