Skip to content

Conversation

@alegmarra
Copy link

@alegmarra alegmarra commented Oct 25, 2022

This refactor includes:

  • Add clarifying comments
  • Hide products that are not used
  • Enforce single product for 'payment_initiation' link-token.
  • Skip public token exchange for 'payment_initiation' flow.

Payment Initiation Product
Screenshot 2022-10-25 at 13 42 10

Account Information Products
Screenshot 2022-10-25 at 13 49 21

phoenixy1
phoenixy1 previously approved these changes Oct 25, 2022
Copy link
Contributor

@phoenixy1 phoenixy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! I didn't go over this in immense detail, but I did do a quick regression test on node just to make sure the previous flow didn't break. lmk if there's anything you'd like special scrutiny on.

.env.example Outdated
@@ -1,24 +1,32 @@
# Get your Plaid API keys from the dashboard: https://dashboard.plaid.com/account/keys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know that you didn't break this, but this url is actually wrong -- it should be https://dashboard.plaid.com/team/keys -- while you're at it would you mind updating it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review Alex!
I don't have permissions to merge, so if this looks good to you, can you please go ahead and merge it?

@phoenixy1 phoenixy1 merged commit 8b7fdfb into plaid:master Oct 26, 2022
@alegmarra alegmarra deleted the EUWECRY-1084 branch October 27, 2022 06:27
SpencerHHurst pushed a commit to SpencerHHurst/quickstart that referenced this pull request Jul 10, 2024
EUWECRY-1084: Refactor Quickstart app for UK/EU payment initiation
fisherrjd pushed a commit to fisherrjd/quickstart that referenced this pull request Oct 12, 2024
EUWECRY-1084: Refactor Quickstart app for UK/EU payment initiation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants