-
Notifications
You must be signed in to change notification settings - Fork 313
392 restructure october 2025 #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the reorganization here. I've added a few comments, mostly minor changes.
As a more general comment - I've noticed a significant mismatch between notebook filenames and titles in many cases - e.g. "calculate_water_extent_analysis_ready_planetscope.ipynb" vs "Intro to ARPS data in Planet Insights Platform".
- Is this something worth improving?
- If so, we should also add guidance around this to the CONTRIBUTING.md
I feel like these types of changes can come after the reorganization, what do you think? I think it can be a gradual improvement over time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TOC updates look good, added some comments on the Auth updates
Agreed, I think that can be part of the per-notebook cleanup. Though we'll probably want to call that out specifically when requesting help from other teams. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, nothing more to add
|
STILL NEED TO DO: all of the colab links are broken- once this is finalized, I will update