Skip to content

Conversation

matthew-ballard
Copy link
Contributor

@matthew-ballard matthew-ballard commented Oct 16, 2025

  • snake_case
  • ordered notebooks when relevant with 0_, 1_
  • contributing guide is updated to reflect standards
  • uses new proposed hierarchy
  • deprecate handful of notebooks
  • adds a new TOC of notebooks
  • updates to the main repo readme file
  • removed tests. The test script was not working, and not being used. We should rethink approach to tests later.

STILL NEED TO DO: all of the colab links are broken- once this is finalized, I will update

@matthew-ballard matthew-ballard linked an issue Oct 16, 2025 that may be closed by this pull request
7 tasks
@matthew-ballard matthew-ballard self-assigned this Oct 16, 2025
@matthew-ballard matthew-ballard review requested due to automatic review settings October 16, 2025 21:59
@matthew-ballard
Copy link
Contributor Author

Also closes #387 #389 and #391

@matthew-ballard matthew-ballard marked this pull request as ready for review October 21, 2025 16:32
Copy link
Contributor

@tbarsballe tbarsballe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the reorganization here. I've added a few comments, mostly minor changes.

As a more general comment - I've noticed a significant mismatch between notebook filenames and titles in many cases - e.g. "calculate_water_extent_analysis_ready_planetscope.ipynb" vs "Intro to ARPS data in Planet Insights Platform".

  1. Is this something worth improving?
  2. If so, we should also add guidance around this to the CONTRIBUTING.md

@matthew-ballard
Copy link
Contributor Author

As a more general comment - I've noticed a significant mismatch between notebook filenames and titles in many cases - e.g. "calculate_water_extent_analysis_ready_planetscope.ipynb" vs "Intro to ARPS data in Planet Insights Platform". Is this something worth improving?

I feel like these types of changes can come after the reorganization, what do you think? I think it can be a gradual improvement over time

Copy link
Contributor

@tbarsballe tbarsballe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOC updates look good, added some comments on the Auth updates

@tbarsballe
Copy link
Contributor

As a more general comment - I've noticed a significant mismatch between notebook filenames and titles in many cases - e.g. "calculate_water_extent_analysis_ready_planetscope.ipynb" vs "Intro to ARPS data in Planet Insights Platform". Is this something worth improving?

I feel like these types of changes can come after the reorganization, what do you think? I think it can be a gradual improvement over time

Agreed, I think that can be part of the per-notebook cleanup. Though we'll probably want to call that out specifically when requesting help from other teams.

Copy link
Contributor

@sbueche sbueche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nothing more to add

@matthew-ballard
Copy link
Contributor Author

matthew-ballard commented Oct 22, 2025

  • update colab links in all noteboks
  • add a callout for Planet Sandbox Data notebooks to replace this current landing page used in the trial
  • finish doc site update to push at the same time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

restructure fy26q3

3 participants