Skip to content

Conversation

carl-alexander-adams
Copy link
Collaborator

  • Improve the user experience around old stale sessions that appear to be
    initialized, but are actually expired. This is done by providing the new
    utility method Auth.ensure_request_authenticator_is_ready().
  • Save computed expiration time and issued time in token files. This allows
    for the persistence of this information when dealing with opaque tokens.
  • Support non-expiring tokens.

@carl-alexander-adams carl-alexander-adams changed the title CG-1904 improve expired session ux DRAFT: CG-1904 improve expired session ux Oct 5, 2025
Copy link

@tbarsballe tbarsballe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see the backwards-compatibility I noted, but I don't think that's strictly necessary - let me know what you think and I could change this to approved

Copy link

@tbarsballe tbarsballe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following on from discussion, it appears my concerns around backwards compatibility are not applicable, as expiry is parsed from the JWT upon initial load.

As such, marking this as approved (though there is still the one comment that you could fix or not)

@carl-adams-planet carl-adams-planet changed the title DRAFT: CG-1904 improve expired session ux CG-1904 improve expired session ux Oct 8, 2025
@carl-adams-planet
Copy link
Collaborator

Following on from discussion, it appears my concerns around backwards compatibility are not applicable, as expiry is parsed from the JWT upon initial load.

As such, marking this as approved (though there is still the one comment that you could fix or not)

I'll still go ahead and put a note in the change log. on the one in a billion chance someone used this with an opaque token somewhere.

@carl-adams-planet carl-adams-planet merged commit 63a478d into main Oct 8, 2025
30 checks passed
@carl-adams-planet carl-adams-planet deleted the cx/CG-1904--improve-expired-session-ux branch October 8, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants