-
Notifications
You must be signed in to change notification settings - Fork 0
CG-1904 improve expired session ux #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CG-1904 improve expired session ux #45
Conversation
…ot seem to install cleanly from pip under python 3.14, and this is breaking unrelated test pipelines.
…anch to front-run the main MR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see the backwards-compatibility I noted, but I don't think that's strictly necessary - let me know what you think and I could change this to approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following on from discussion, it appears my concerns around backwards compatibility are not applicable, as expiry is parsed from the JWT upon initial load.
As such, marking this as approved (though there is still the one comment that you could fix or not)
I'll still go ahead and put a note in the change log. on the one in a billion chance someone used this with an opaque token somewhere. |
initialized, but are actually expired. This is done by providing the new
utility method
Auth.ensure_request_authenticator_is_ready()
.for the persistence of this information when dealing with opaque tokens.