docker: fix arm64 image and generate multiarch manifests #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goreleaser was creating an arm64 image containing the correct arm64 build of `ghcommit` but the rest of the packages (eg: /usr/bin/git) were amd64 binaries. Fix this by using buildx and explicitly setting --platform to linux/arm64 also we were not yet creating multi-arch manifests so downstream consumers would need to explicitly pull the `<tag>-arm64` tag variants. this should no longer be necessary with the creation of multi-arch manifests
dctrwatson
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goreleaser was creating an arm64 image containing the correct arm64 build of
ghcommitbut the rest of the packages (eg: /usr/bin/git) were amd64 binaries. Fix this by using buildx and explicitly setting --platform to linux/arm64also we were not yet creating multi-arch manifests so downstream consumers would need to explicitly pull the
<tag>-arm64tag variants. this should no longer be necessary with the creation of multi-arch manifestsre: