-
Notifications
You must be signed in to change notification settings - Fork 65
Reintroduce special shapes for some ArchiMate elements #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and technology node, depending on $ARCH_SPECIAL_SHAPES setting
… and technology node, depending on $ARCH_SPECIAL_SHAPES setting
… prepare-alternative-shapes
…-shapes # Conflicts: # dist/plantuml-stdlib/stdlib/archimate/Archimate.puml
…; update README.md to explain how to combine nesting and special shapes
Potherca
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor points of comment, but nothing that would block a merge.
Potherca
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thie PR adds special shapes for
Special shapes are activated individually by adding
$special=%true()when creating the element, or by setting a global variable!global $ARCH_SPECIAL_SHAPES=%true(). In the latter case, override on individual shapes is done by providing$special=%false().Most of these special shapes allow nesting elements in them, and for those that do not support it, the original shape is used as long as callers use
$nest=%true().This partially fixes #46 , for those ArchiMate shapes that match an existing PlantUML shape.
Additionally, the incorrect use of the literals
trueandfalsehas been corrected to use%true()and%false().