Skip to content

Conversation

@thijstriemstra
Copy link
Contributor

No description provided.

@ivankravets
Copy link
Member

Caching is the optional feature. So, could we allow people to personally decide to use it or not?

@thijstriemstra
Copy link
Contributor Author

Caching is a best practice and we can help the Python Software Foundation's bandwidth usage by suggesting this in the docs. Same goes for platformio resources. Not caching is a big waste of resources and money. I'll leave it up to you to decide.

@ivankravets
Copy link
Member

Good, let's discuss the PR.

${{ hashFiles('**/lockfiles') }}

Is it valid for PlatformIO? What does mean lockfiles?

  • name: Install dependencies
    run: |
    python -m pip install --upgrade pip
    pip install platformio

Could we replace this part with?

    - name: Install PlatformIO Core
      run: |
        pip install -U platformio

Please re-test if it works.

Thanks!

@thijstriemstra
Copy link
Contributor Author

Is it valid for PlatformIO? What does mean lockfiles?

Afaik they are files placed by github actions to mark a directory as cached"

Could we replace this part with?

I would definitely try to upgrade pip everytime and suggest:

- name: Install PlatformIO Core
      run: |
        python -m pip install --upgrade pip
        pip install -U platformio

I'll update the PR.

@ivankravets ivankravets merged commit 6ab343f into platformio:develop Nov 30, 2020
@ivankravets
Copy link
Member

Thanks!

aofaof0907 pushed a commit to aoaoff0907/platformio-docs that referenced this pull request Jul 27, 2021
* ci: use cache in github actions

* address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants