Fix version substitution for releases #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
The purpose of this PR is to fix the version substitution for releases. Key changes include updating the version, commit, date, and builtBy substitution keys from the "commands" package to the "internal/config" package in the GoReleaser configuration for two build targets.
Comments suppressed due to low confidence (2)
.goreleaser.yaml:45
- Verify that the updated substitution key 'github.com/platformsh/cli/internal/config.Version' correctly matches the variable definitions in your codebase for version substitution, ensuring consistency with the intended release process.
+ - -X "github.com/platformsh/cli/internal/config.Version={{.Version}}"
.goreleaser.yaml:71
- Verify that the updated substitution key in this build block is consistent with your configuration, and that the internal/config variables are defined as expected for release versioning.
+ - -X "github.com/platformsh/cli/internal/config.Version={{.Version}}"
pjcdawkins
reviewed
May 8, 2025
pjcdawkins
force-pushed
the
hotfix/upsun-version
branch
from
2e0bfb0 to
35ccca7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.