Skip to content

chore: add test case for pre_start on composable #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 20, 2025
Merged

chore: add test case for pre_start on composable #256

merged 4 commits into from
Oct 20, 2025

Conversation

@spk
Copy link
Contributor

@spk spk commented Oct 15, 2025 •
edited
Loading

why

upsun lint

on a composable project

how

this should fail with

=== RUN   Test_validateUpsunConfig/stack
    validator_test.go:303: validateUpsunConfig() error = applications.app1.web.commands: start is required, wantErr false

but the start command is not mandatory on php and the composable image. Same for post_start.

@akalipetis akalipetis self-requested a review October 20, 2025 10:12
akalipetis
akalipetis approved these changes Oct 20, 2025
View reviewed changes
Copy link
Member

@akalipetis akalipetis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akalipetis akalipetis merged commit 1f76794 into main Oct 20, 2025
3 checks passed
@akalipetis akalipetis deleted the require-start-stack-php branch October 20, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akalipetis akalipetis akalipetis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spk @akalipetis