result status for certain activities has been changed

[gilzow]

Priority

3 - Not urgent - can be addressed as team bandwidth permits

Where should the changes be made?

Not entirely sure, but at least on
https://docs.upsun.com/integrations/activity/reference.html#result
https://fixed.docs.upsun.com/integrations/activity/reference.html#result

What exactly should be updated?

Previously, when activating or deploying an environment, the Result for that activity was dependent on whether or not the build and deploy completed. Meaning, that even if you had scripts fail that were triggered by the deploy or post_deploy hooks, the activity for the environment activation (deployment) was still returned as success. This has now changed. If any scripts in those hooks returns a non-zero exit code, the activity is marked as failure.

This failure state is indicated in both the api/cli and also in the console.

Optional: Additional context

There's some discussion as to whether or not this change will be altered to better convey the true state of the activity (ie environment.activate succeeded, but post_deploy failed). Will update this issue as we receive more information.