[#1043] Add support for chunked transfer of binary data, plus fix of bug 920.#312
Closed
yeefan wants to merge 4 commits intoplayframework:masterfrom
Closed
[#1043] Add support for chunked transfer of binary data, plus fix of bug 920.#312yeefan wants to merge 4 commits intoplayframework:masterfrom
yeefan wants to merge 4 commits intoplayframework:masterfrom
Conversation
… plus fix of bug 920.
sgodbillon
pushed a commit
to sgodbillon/play
that referenced
this pull request
Aug 17, 2011
mbknor
pushed a commit
to mbknor/play
that referenced
this pull request
Aug 18, 2011
… plus fix of bug 920 (updated to detect if output socket closed in the middle of the transfer).
…ighthouse-1043-patch
Member
|
thanks for pull request. I ended up with something similar to your code plus some tests. I did not pull this pullrequest but I did credit you in commit message. I hope it is ok. thanks. |
Author
|
No problem with me, and thanks for the fix. However, I have the following pull request, to be applied to your code: This pull request simply adds three lines and one test case. There is description in the controller method in the test case. Hope you can accept. Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[#1043] Add support for chunked transfer of binary data, plus fix of bug 920.