Player-OnQuit-BugFixing #154
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increased max players per room to 4 and updated score text assignment logic in GameManager2d.cs. Changed mockMode and browser settings in platformer and lobby scenes. Updated build settings to enable 2d-platformer and TestScene, and switched WebGL template to PWA. Added .vsconfig for Visual Studio workload and made minor .vscode/settings.json adjustments.
Introduced a PlayerCountText UI element to display the current number of players in the 2D platformer example. Updated GameManager2d to manage and refresh the player count display when players join or leave.
Introduced a new TextMeshProUGUI field and UI element for displaying 'Hello, World!' in the 2d platformer example. Added RPC registration and logic to show the message on all players' screens when triggered, with automatic clearing after a delay.
Introduced new RPC methods to send and receive custom data types as JSON strings between players. Added IdkCoolClass for demonstration, updated GameManager2d to handle custom data RPCs, and included input handling for triggering these actions. Minor formatting and whitespace adjustments in PlayerController2d.
Enhanced RPC.cs to serialize custom serializable types using JsonUtility. Refactored GameManager2d.cs for better RPC registration, error handling, and data transmission. Updated .vscode and project settings for new solution and WebGL template. Disabled browser in 2d-platformer example scene.
Player-OnQuit-BugFixing
momintlh
requested changes
Oct 20, 2025
Assets/PlayroomKit/Examples/2d-platformer/scripts/GameManager2d.cs
Outdated
Show resolved
Hide resolved
Assets/PlayroomKit/Examples/2d-platformer/scripts/GameManager2d.cs
Outdated
Show resolved
Hide resolved
Assets/PlayroomKit/Examples/2d-platformer/scripts/GameManager2d.cs
Outdated
Show resolved
Hide resolved
Assets/PlayroomKit/Examples/2d-platformer/scripts/GameManager2d.cs
Outdated
Show resolved
Hide resolved
Assets/PlayroomKit/Examples/2d-platformer/scripts/GameManager2d.cs
Outdated
Show resolved
Hide resolved
Assets/PlayroomKit/Examples/2d-platformer/scripts/GameManager2d.cs
Outdated
Show resolved
Hide resolved
Adding and removing of players is handled dynamically now also scores are handled and the color are fetched from
Changed RemovePlayer from static to instance method and removed redundant instance lookup. Streamlined player removal logic and direct access to class members for improved clarity and maintainability.
Updated the DisplayHelloWorldRPC method to accept data and caller parameters, allowing custom messages to be displayed. The RPC call now sends 'Hello, World!' as data, and the text display logic uses the provided data instead of a hardcoded string.
Introduces TestDictionaryData and NestedData classes for structured data transfer via RPC. Registers a new 'TestDictionaryRPC' method, sends test data on 'P' key press, and adds a handler to deserialize and log the received data.
momintlh
requested changes
Oct 23, 2025
Assets/PlayroomKit/Examples/2d-platformer/scripts/GameManager2d.cs
Outdated
Show resolved
Hide resolved
Refactored GameManager2d to distinguish between TestData and dictionary-based RPC calls, adding new input handling for sending both types. Updated RPC.cs to better serialize/deserialize complex and dictionary data, improving error handling and JSON conversion. Updated .gitignore to exclude .vsconfig and .vscode/settings.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following are the updates in this fork :-
Enabled 4 playes Support for 2d-platform-scene.
Count for current players in the lobby.
feature to send string using RPC on all connected player.
feature to send custom data types using RPC