Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Conversation

@mmarkelov
Copy link
Member

@mmarkelov mmarkelov commented Feb 6, 2020

I just think about support this feature, but I haven't got any ideas about clean and simple API.

In this PR my thoughts about it. You can add come configuration to support specific version through jest-playwright.config.js :

module.exports = {
    browser: 'firefox',
    useStandaloneVersion: true,
    ...
}

or with env params: BROWSER=firefox USE_STANDALONE_VERSION=true jest

Also I should think about peerDependencies, should it be replaced with optionalDependencies?

#7

@mxschmitt
Copy link
Collaborator

We should probably not move it to peerDependencies, at least these standalone packages. Because otherwise there would be always the warnings during the installation. So for me I would move playwright + standalone versions to optionalDependencies, that should be ok.

@mmarkelov
Copy link
Member Author

I made some changes with this PR. I suppose we must keep it as simple as possible, so I rewrite it to check out package.json for installed playwright package. So you don't need to provide extra params to use specific package

@mmarkelov mmarkelov merged commit 936936d into master Feb 9, 2020
@mxschmitt mxschmitt deleted the Ability-to-support-specific-browser branch February 23, 2020 09:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants