Skip to content

Conversation

@plokhotnyuk
Copy link
Owner

No description provided.

@plokhotnyuk plokhotnyuk force-pushed the master branch 3 times, most recently from b1def2d to 75f2365 Compare September 3, 2025 12:35
@plokhotnyuk plokhotnyuk force-pushed the opaque-types branch 3 times, most recently from 1189d21 to 07e2783 Compare September 3, 2025 18:37
@plokhotnyuk plokhotnyuk force-pushed the master branch 2 times, most recently from 1661a93 to 7ef735a Compare September 5, 2025 07:43
@plokhotnyuk plokhotnyuk force-pushed the opaque-types branch 4 times, most recently from 7e98015 to 159be50 Compare September 5, 2025 14:26
@plokhotnyuk plokhotnyuk marked this pull request as ready for review September 5, 2025 14:32
@plokhotnyuk plokhotnyuk requested a review from Copilot September 5, 2025 14:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds codec generation support for Scala 3 opaque types in the jsoniter-scala-macros library. The changes enable automatic JSON serialization and deserialization of opaque types by treating them as their underlying types.

  • Adds codec generation logic for opaque types that delegates to the underlying type's codec
  • Introduces test cases demonstrating opaque type serialization/deserialization
  • Updates terminology from "opaque types" to "newtypes" in existing test descriptions

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
JsonCodecMaker.scala Core implementation adding opaque type support in read/write/key codec generation
JsonCodecMakerNewTypeSpec.scala Test cases for opaque types and updates to existing Year type usage
JsonCodecMakerSpec.scala Minor terminology update in test description

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@plokhotnyuk plokhotnyuk merged commit f4f7f08 into master Sep 6, 2025
4 checks passed
@plokhotnyuk plokhotnyuk deleted the opaque-types branch September 6, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants