Update message Add-on control panel #4574
Conversation
✅ Deploy Preview for volto canceled.
|
|
By now just english provides a detailed help message on installing backend addons. I found this issue while updating my training. |
|
Why is the default message so long and the existing translations so short? If the defaultMessage is such long, the translations should have been translations of that defaultMessage, right? It's just a curiosity, because I see that the original defaultMessage is really longer than all the existing translations... |
There was a problem hiding this comment.
@erral The existing short translations may have been added before the defaultMessage was included in the .po files -- for example it was not there when you added the Spanish translation in b944a7d#diff-631af0849c562ae85096b429d9c5d16c5d0ddde5aa14030bd9853f2c083da79cR64
The changes here look good to me.
|
Yes I am not saying that the changes are not good. It was just because when using any translation helping tools, usually they offer an option to do the translation based on the default message this was strange. Just that. We can also mark the translations as fuzzy, which is what i18ndude does when the default message is changed, but that invalidates the translations usually, at least in Plone. |
ksuess
force-pushed
the
message-add-ons-controlpanel
branch
from
7af3193
to
420aeee
Compare
|
Eliminating the hint on buildout. Thanks for reviewing and approving. The translations should be updated too. I will propose translations for german. Please check if an update for your languages could be reasonable too. |
* master: (67 commits) Add current page parameter to the route in the listing and search block pagination (#4159) Fixed wrong localization on password reset page(#4656) (#4657) Release notes for 16.19.0 (#4655) Razzle upgrade notice in upgrade guide (#4641) Release generate-volto 7.0.0-alpha.3 Update to latest Razzle - needed since #3997. This fixes the duplicated Razzles issue (#4640) 3092 improve spellcheck (#4633) developer process for first time contributing (#4617) Trigger CI on pull_request event (#4629) Pining of `pydata-sphinx-theme` and `sphinx-book-theme`, CI is complaining. (#4626) Set sameSite in `18N_LANGUAGE` cookie (#4627) Update simple-git (#4546) DefaultView (blocks disabled): Show field name as tip on hover of label (#4598) Fix regexp that checks valid URLs and improve tests (#4601) Release 17.0.0-alpha.3 Update changelog relese 16.18.0 (#4596) InternalURl helper method should incorporate externalRoutes settings … (#4560) Update message Add-on control panel (#4574) Fix video warnings link errors (#4578) Using Vale in CI for spellcheck (#4423) ...
No description provided.