Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3092 improve spellcheck #4633

Merged
merged 5 commits into from
Apr 3, 2023
Merged

3092 improve spellcheck #4633

merged 5 commits into from
Apr 3, 2023

Conversation

utkkkarshhh
Copy link
Member

improved spellcheck and consistency for spelling by adding "NodeJS and JavaScript" to "accept.txt" and others in "reject.txt"

@utkkkarshhh
3092 improve spellcheck
5350930 
improved spellcheck and consistency for spelling by adding "NodeJS and JavaScript" to "accept.txt" and others in "reject.txt"
@mister-roboto
Copy link

@utkkkarshhh you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

@netlify
Copy link

netlify bot commented Apr 1, 2023 •
edited
Loading

✅ Deploy Preview for volto canceled.

Name Link
🔨 Latest commit d716399
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/642aa471f607280008754bc1

@utkkkarshhh
Copy link
Member Author

utkkkarshhh commented Apr 1, 2023 •
edited
Loading

How to add entry in Changelog verifier? Also i've already sent an email with Plone Contributors Agreement to agreements@plone.org. @stevepiercy

@stevepiercy
Copy link
Collaborator

@utkkkarshhh for change log see https://6.docs.plone.org/volto/developer-guidelines/contributing.html#create-a-pull-request

A human will review your PCA and notify you when you are approved within a few business days. Please post a comment here when you are approved. Thank you!

@mister-roboto
Copy link

@utkkkarshhh you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

@mister-roboto
Copy link

@utkkkarshhh you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

@utkkkarshhh
Copy link
Member Author

I've been added as a contributor to the Plone Organisation.

stevepiercy
stevepiercy requested changes Apr 3, 2023
View reviewed changes
news/3092.documentation Outdated Show resolved Hide resolved
@utkkkarshhh @stevepiercy
Updated news/3092.documentation
d716399 
Altered the log as per required changes.

Co-authored-by: Steve Piercy <web@stevepiercy.com>
@stevepiercy
Copy link
Collaborator

Thank you @utkkkarshhh. I will merge as soon as the jobs all pass.

@utkkkarshhh
Copy link
Member Author

Thank you so much for assisting.

@stevepiercy stevepiercy merged commit cb9dfd0 into plone:master Apr 3, 2023
@stevepiercy
Copy link
Collaborator

@utkkkarshhh if you would like to ensure that this change also gets imported into the main documentation, would you please submit a PR in https://github.com/plone/documentation?

@utkkkarshhh
Copy link
Member Author

utkkkarshhh commented Apr 3, 2023 •
edited
Loading

@stevepiercy I've opened a PR at plone/documentation#1484
Also there's a file at "documentation/docs/spelling_wordlist.txt" which contains the reject.txt contents as well.

sneridagh pushed a commit that referenced this pull request Apr 4, 2023
@utkkkarshhh @stevepiercy @sneridagh
3092 improve spellcheck (#4633)
550d35d 
Co-authored-by: Steve Piercy <web@stevepiercy.com>
sneridagh added a commit that referenced this pull request Apr 4, 2023
@sneridagh @utkkkarshhh @stevepiercy
3092 improve spellcheck (#4633) (#4651)
bbd1a2e 
Co-authored-by: Utkarsh Bhardwaj <67866657+utkkkarshhh@users.noreply.github.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
sneridagh added a commit that referenced this pull request Apr 5, 2023
@sneridagh
Merge branch 'master' into rowblock
e795d32 
* master: (67 commits)
  Add current page parameter to the route in the listing and search block pagination (#4159)
  Fixed wrong localization on password reset page(#4656) (#4657)
  Release notes for 16.19.0 (#4655)
  Razzle upgrade notice in upgrade guide (#4641)
  Release generate-volto 7.0.0-alpha.3
  Update to latest Razzle - needed since #3997. This fixes the duplicated Razzles issue (#4640)
  3092 improve spellcheck (#4633)
  developer process for first time contributing (#4617)
  Trigger CI on pull_request event (#4629)
  Pining of `pydata-sphinx-theme` and `sphinx-book-theme`, CI is complaining. (#4626)
  Set sameSite in `18N_LANGUAGE` cookie (#4627)
  Update simple-git (#4546)
  DefaultView (blocks disabled): Show field name as tip on hover of label (#4598)
  Fix regexp that checks valid URLs and improve tests (#4601)
  Release 17.0.0-alpha.3
  Update changelog relese 16.18.0 (#4596)
  InternalURl helper method should incorporate externalRoutes settings … (#4560)
  Update message Add-on control panel (#4574)
  Fix video warnings link errors (#4578)
  Using Vale in CI for spellcheck (#4423)
  ...
sneridagh added a commit that referenced this pull request Apr 10, 2023
@sneridagh
Merge branch 'master' into quanta
5419196 
* master: (326 commits)
  Make URL a literal string to fix broken link (#4667)
  Move developer guidelines to contributing #4665 (#4666)
  Update Volto contributing to align with and refer to the new Plone co… (#4634)
  Release @plone/scripts 3.0.0
  Changelog
  Added querystring search get option (#4658)
  Add current page parameter to the route in the listing and search block pagination (#4159)
  Fixed wrong localization on password reset page(#4656) (#4657)
  Release notes for 16.19.0 (#4655)
  Razzle upgrade notice in upgrade guide (#4641)
  Release generate-volto 7.0.0-alpha.3
  Update to latest Razzle - needed since #3997. This fixes the duplicated Razzles issue (#4640)
  3092 improve spellcheck (#4633)
  developer process for first time contributing (#4617)
  Trigger CI on pull_request event (#4629)
  Pining of `pydata-sphinx-theme` and `sphinx-book-theme`, CI is complaining. (#4626)
  Set sameSite in `18N_LANGUAGE` cookie (#4627)
  Update simple-git (#4546)
  DefaultView (blocks disabled): Show field name as tip on hover of label (#4598)
  Fix regexp that checks valid URLs and improve tests (#4601)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepiercy stevepiercy stevepiercy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@utkkkarshhh @mister-roboto @stevepiercy