Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

developer process for first time contributing #4617

Merged
merged 3 commits into from Mar 31, 2023

Conversation

fredvd
Copy link
Sponsor Member

@fredvd fredvd commented Mar 27, 2023

No description provided.

@netlify
Copy link

netlify bot commented Mar 27, 2023

Deploy Preview for volto ready!

Name Link
🔨 Latest commit 258aa34
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/6422e649c80e7f0008570d15
😎 Deploy Preview https://deploy-preview-4617--volto.netlify.app/developer-guidelines/contributing.html
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress
Copy link

cypress bot commented Mar 27, 2023

Passing run #4721 ↗︎

0 489 20 0 Flakiness 0

Details:

Update docs/source/developer-guidelines/contributing.md
Project: Volto Commit: 258aa34821
Status: Passed Duration: 14:12 💡
Started: Mar 28, 2023 1:09 PM Ended: Mar 28, 2023 1:23 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Sponsor Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except one clarification and one typo, on the same line, see suggestion.

docs/source/developer-guidelines/contributing.md Outdated Show resolved Hide resolved
Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did we fix the fork PR GHA run issue?

@stevepiercy
Copy link
Collaborator

Please do not merge this. See plone/documentation#1278

Things that are global to Plone, such as the CA, belong in the main docs, not in Volto. Only things that are unique to Volto belong in Volto's docs. For global things, Volto docs should refer to the main docs.

@fredvd
Copy link
Sponsor Member Author

fredvd commented Mar 28, 2023

@stevepiercy I wrote this yesterday on Discord:

I've started extending the 'contributing' docmentation in the Volto subsection of the docs at #4617 . This is now specifc for Volto and should be generalised in its own section at the root of the official documentation, there are issues for that. But as we have the most influx of first time contributor for Volto, let's beta-test better explanation of the workflow and expections for Volto first.

@stevepiercy
Copy link
Collaborator

@fredvd although I appreciate your enthusiasm and desire to fix only Volto contributing docs at this time, instead please redirect your energy and efforts to improve the global Plone contributing docs for the benefit of all Plone developers.

The recent spike in newbie traffic will subside further after Apr 4, when the GSoC proposal period closes. It already has dropped off dramatically, compared to last week. 90% of the posts from newbies are asking to be assigned to an issue , who then disappear forever. A handful of PRs were created, and we can handle those as one-offs.

Co-authored-by: Maurits van Rees <maurits@vanrees.org>
@fredvd fredvd merged commit dac283a into master Mar 31, 2023
24 of 26 checks passed
@fredvd fredvd deleted the docs_first_time_contributing branch March 31, 2023 19:05
sneridagh added a commit that referenced this pull request Apr 3, 2023
* master:
  developer process for first time contributing (#4617)
  Trigger CI on pull_request event (#4629)
  Pining of `pydata-sphinx-theme` and `sphinx-book-theme`, CI is complaining. (#4626)
  Set sameSite in `18N_LANGUAGE` cookie (#4627)
sneridagh added a commit that referenced this pull request Apr 5, 2023
* master: (67 commits)
  Add current page parameter to the route in the listing and search block pagination (#4159)
  Fixed wrong localization on password reset page(#4656) (#4657)
  Release notes for 16.19.0 (#4655)
  Razzle upgrade notice in upgrade guide (#4641)
  Release generate-volto 7.0.0-alpha.3
  Update to latest Razzle - needed since #3997. This fixes the duplicated Razzles issue (#4640)
  3092 improve spellcheck (#4633)
  developer process for first time contributing (#4617)
  Trigger CI on pull_request event (#4629)
  Pining of `pydata-sphinx-theme` and `sphinx-book-theme`, CI is complaining. (#4626)
  Set sameSite in `18N_LANGUAGE` cookie (#4627)
  Update simple-git (#4546)
  DefaultView (blocks disabled): Show field name as tip on hover of label (#4598)
  Fix regexp that checks valid URLs and improve tests (#4601)
  Release 17.0.0-alpha.3
  Update changelog relese 16.18.0 (#4596)
  InternalURl helper method should incorporate externalRoutes settings … (#4560)
  Update message Add-on control panel (#4574)
  Fix video warnings link errors (#4578)
  Using Vale in CI for spellcheck (#4423)
  ...
sneridagh added a commit that referenced this pull request Apr 10, 2023
* master: (326 commits)
  Make URL a literal string to fix broken link (#4667)
  Move developer guidelines to contributing #4665 (#4666)
  Update Volto contributing to align with and refer to the new Plone co… (#4634)
  Release @plone/scripts 3.0.0
  Changelog
  Added querystring search get option (#4658)
  Add current page parameter to the route in the listing and search block pagination (#4159)
  Fixed wrong localization on password reset page(#4656) (#4657)
  Release notes for 16.19.0 (#4655)
  Razzle upgrade notice in upgrade guide (#4641)
  Release generate-volto 7.0.0-alpha.3
  Update to latest Razzle - needed since #3997. This fixes the duplicated Razzles issue (#4640)
  3092 improve spellcheck (#4633)
  developer process for first time contributing (#4617)
  Trigger CI on pull_request event (#4629)
  Pining of `pydata-sphinx-theme` and `sphinx-book-theme`, CI is complaining. (#4626)
  Set sameSite in `18N_LANGUAGE` cookie (#4627)
  Update simple-git (#4546)
  DefaultView (blocks disabled): Show field name as tip on hover of label (#4598)
  Fix regexp that checks valid URLs and improve tests (#4601)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants