Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultView (blocks disabled): Show field name as tip on hover of label #4598

Merged
merged 1 commit into from Mar 23, 2023

Conversation

ksuess
Copy link
Member

@ksuess ksuess commented Mar 22, 2023

No description provided.

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit c5f7861
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/641b58e539380900086e6987

Copy link
Sponsor Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be okay for editors but I don't think it's something I would want to display in a tooltip for anonymous viewers.

@tiberiuichim
Copy link
Contributor

@davisagli that view is very rough. If you're exposing end users to it, you either have bigger problems, or they're the type of users that don't mind that info, or they find it useful.

@davisagli
Copy link
Sponsor Member

@tiberiuichim I guess you are probably right in most cases.

@cypress
Copy link

cypress bot commented Mar 22, 2023

Passing run #4648 ↗︎

0 489 20 0 Flakiness 0

Details:

DefaultView (blocks disabled): Show field name as tip on hover of label
Project: Volto Commit: c5f786149e
Status: Passed Duration: 13:29 💡
Started: Mar 22, 2023 7:39 PM Ended: Mar 22, 2023 7:53 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@sneridagh
Copy link
Member

I agree that this view is kind of a rough fallback view, ideally an integrator should always provide a better tailored one.

@sneridagh sneridagh merged commit fbd4fe5 into master Mar 23, 2023
23 checks passed
@sneridagh sneridagh deleted the Show-field-name-as-tip-on-hover-of-label branch March 23, 2023 15:31
sneridagh added a commit that referenced this pull request Apr 5, 2023
* master: (67 commits)
  Add current page parameter to the route in the listing and search block pagination (#4159)
  Fixed wrong localization on password reset page(#4656) (#4657)
  Release notes for 16.19.0 (#4655)
  Razzle upgrade notice in upgrade guide (#4641)
  Release generate-volto 7.0.0-alpha.3
  Update to latest Razzle - needed since #3997. This fixes the duplicated Razzles issue (#4640)
  3092 improve spellcheck (#4633)
  developer process for first time contributing (#4617)
  Trigger CI on pull_request event (#4629)
  Pining of `pydata-sphinx-theme` and `sphinx-book-theme`, CI is complaining. (#4626)
  Set sameSite in `18N_LANGUAGE` cookie (#4627)
  Update simple-git (#4546)
  DefaultView (blocks disabled): Show field name as tip on hover of label (#4598)
  Fix regexp that checks valid URLs and improve tests (#4601)
  Release 17.0.0-alpha.3
  Update changelog relese 16.18.0 (#4596)
  InternalURl helper method should incorporate externalRoutes settings … (#4560)
  Update message Add-on control panel (#4574)
  Fix video warnings link errors (#4578)
  Using Vale in CI for spellcheck (#4423)
  ...
sneridagh added a commit that referenced this pull request Apr 10, 2023
* master: (326 commits)
  Make URL a literal string to fix broken link (#4667)
  Move developer guidelines to contributing #4665 (#4666)
  Update Volto contributing to align with and refer to the new Plone co… (#4634)
  Release @plone/scripts 3.0.0
  Changelog
  Added querystring search get option (#4658)
  Add current page parameter to the route in the listing and search block pagination (#4159)
  Fixed wrong localization on password reset page(#4656) (#4657)
  Release notes for 16.19.0 (#4655)
  Razzle upgrade notice in upgrade guide (#4641)
  Release generate-volto 7.0.0-alpha.3
  Update to latest Razzle - needed since #3997. This fixes the duplicated Razzles issue (#4640)
  3092 improve spellcheck (#4633)
  developer process for first time contributing (#4617)
  Trigger CI on pull_request event (#4629)
  Pining of `pydata-sphinx-theme` and `sphinx-book-theme`, CI is complaining. (#4626)
  Set sameSite in `18N_LANGUAGE` cookie (#4627)
  Update simple-git (#4546)
  DefaultView (blocks disabled): Show field name as tip on hover of label (#4598)
  Fix regexp that checks valid URLs and improve tests (#4601)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants