Update razzle and react-dev-utils #3997
Conversation
✅ Deploy Preview for volto canceled.
|
Passing run #4397 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
@davisagli @tiberiuichim this is a breaking change, since we are forced to have the dependency set in all projects, so we have to tell everybody to update. If we do not, the build gets crazy if it has two different Razzle (with their own deps) in there. We could do it, but maybe it's not worth to push for this minor change now? |
|
@sneridagh I don't think it will work if we can never make bugfix updates to our dependencies. We need to do that to fix security vulnerabilities. But the main point here is the update to react-dev-utils (because that unblocks updating some transitive dependencies that are vulnerable). I just updated razzle in passing because I noticed there was a new bugfix release. So I could try taking out the razzle update. |
|
@davisagli yes, I know... this sucks... I just wanted to bring it to the table. Maybe we could find a solution for it... but as long as we have to maintain the direct dependencies in the projects, we will have to deal with this somehow. Even if we make that super easy to manage for the integrators, it would imply an action to be taken, thus the need for mark it as breaking. 😞 |
|
@sneridagh It might not be necessary for projects to specify a razzle version directly now that we removed the razzle dependency from |
|
@sneridagh btw, maybe we should have a test that runs using a project that was generated with volto 16.0.0 rather than the latest generator, so that we can catch if we change something that requires project updates? |
|
@sneridagh Anyway, we can still merge it for master and just not backport it to 16.x.x, right? (If I add something to the upgrade guide for volto 17) |
@sneridagh iirc, the npm way of doing this is peerDependencies, razzle should be one of them. I would really really love to have an overhaul of the volto dependency system to be more standard, and yarn3 already pushed us somewhat in this direction, but it's quite a biggie and definitely breaking, but also very beneficial in the long run imho. ...in my dreams volto should become just the framework to be used as an installed dependency, not a razzle project itself. 😬 I meant to discuss this point sometimes in the future, but this thread called for a spoiler :) |
|
@sneridagh We should revisit this one for 17 |
davisagli
force-pushed
the
update-dev-tools
branch
from
0b64c6d
to
2f0f109
Compare
Co-authored-by: Víctor Fernández de Alba <sneridagh@gmail.com>
* master: (67 commits) Add current page parameter to the route in the listing and search block pagination (#4159) Fixed wrong localization on password reset page(#4656) (#4657) Release notes for 16.19.0 (#4655) Razzle upgrade notice in upgrade guide (#4641) Release generate-volto 7.0.0-alpha.3 Update to latest Razzle - needed since #3997. This fixes the duplicated Razzles issue (#4640) 3092 improve spellcheck (#4633) developer process for first time contributing (#4617) Trigger CI on pull_request event (#4629) Pining of `pydata-sphinx-theme` and `sphinx-book-theme`, CI is complaining. (#4626) Set sameSite in `18N_LANGUAGE` cookie (#4627) Update simple-git (#4546) DefaultView (blocks disabled): Show field name as tip on hover of label (#4598) Fix regexp that checks valid URLs and improve tests (#4601) Release 17.0.0-alpha.3 Update changelog relese 16.18.0 (#4596) InternalURl helper method should incorporate externalRoutes settings … (#4560) Update message Add-on control panel (#4574) Fix video warnings link errors (#4578) Using Vale in CI for spellcheck (#4423) ...
* master: (326 commits) Make URL a literal string to fix broken link (#4667) Move developer guidelines to contributing #4665 (#4666) Update Volto contributing to align with and refer to the new Plone co… (#4634) Release @plone/scripts 3.0.0 Changelog Added querystring search get option (#4658) Add current page parameter to the route in the listing and search block pagination (#4159) Fixed wrong localization on password reset page(#4656) (#4657) Release notes for 16.19.0 (#4655) Razzle upgrade notice in upgrade guide (#4641) Release generate-volto 7.0.0-alpha.3 Update to latest Razzle - needed since #3997. This fixes the duplicated Razzles issue (#4640) 3092 improve spellcheck (#4633) developer process for first time contributing (#4617) Trigger CI on pull_request event (#4629) Pining of `pydata-sphinx-theme` and `sphinx-book-theme`, CI is complaining. (#4626) Set sameSite in `18N_LANGUAGE` cookie (#4627) Update simple-git (#4546) DefaultView (blocks disabled): Show field name as tip on hover of label (#4598) Fix regexp that checks valid URLs and improve tests (#4601) ...
No description provided.