Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simple-git #4546

Merged
merged 5 commits into from
Mar 23, 2023
Merged

Update simple-git #4546

merged 5 commits into from
Mar 23, 2023

Conversation

davisagli
Copy link
Sponsor Member

And remove it as a direct dependency of @plone/scripts, because it is not used directly.

@netlify
Copy link

netlify bot commented Mar 15, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit a7b6b1f
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/641c86dbe7fc060008ad95e0

@cypress
Copy link

cypress bot commented Mar 15, 2023

Passing run #4674 ↗︎

0 147 5 0 Flakiness 0

Details:

Merge branch 'master' into deps-simple-git
Project: Volto Commit: a7b6b1fa58
Status: Passed Duration: 13:33 💡
Started: Mar 23, 2023 5:44 PM Ended: Mar 23, 2023 5:58 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@sneridagh
Copy link
Member

@davisagli Since this is a change in @plone/scripts we use to place the changelog in the package.

@davisagli
Copy link
Sponsor Member Author

@sneridagh Oops, I hadn't noticed there is a separate one. Makes sense, I moved it.

@davisagli
Copy link
Sponsor Member Author

@sneridagh Why does it fail the towncrier check now?

@sneridagh
Copy link
Member

@davisagli my bad... I didn't anticipate this for inner packages changelogs.

@davisagli davisagli merged commit 33962f1 into master Mar 23, 2023
@davisagli davisagli deleted the deps-simple-git branch March 23, 2023 18:26
sneridagh added a commit that referenced this pull request Apr 5, 2023
* master: (67 commits)
  Add current page parameter to the route in the listing and search block pagination (#4159)
  Fixed wrong localization on password reset page(#4656) (#4657)
  Release notes for 16.19.0 (#4655)
  Razzle upgrade notice in upgrade guide (#4641)
  Release generate-volto 7.0.0-alpha.3
  Update to latest Razzle - needed since #3997. This fixes the duplicated Razzles issue (#4640)
  3092 improve spellcheck (#4633)
  developer process for first time contributing (#4617)
  Trigger CI on pull_request event (#4629)
  Pining of `pydata-sphinx-theme` and `sphinx-book-theme`, CI is complaining. (#4626)
  Set sameSite in `18N_LANGUAGE` cookie (#4627)
  Update simple-git (#4546)
  DefaultView (blocks disabled): Show field name as tip on hover of label (#4598)
  Fix regexp that checks valid URLs and improve tests (#4601)
  Release 17.0.0-alpha.3
  Update changelog relese 16.18.0 (#4596)
  InternalURl helper method should incorporate externalRoutes settings … (#4560)
  Update message Add-on control panel (#4574)
  Fix video warnings link errors (#4578)
  Using Vale in CI for spellcheck (#4423)
  ...
sneridagh added a commit that referenced this pull request Apr 10, 2023
* master: (326 commits)
  Make URL a literal string to fix broken link (#4667)
  Move developer guidelines to contributing #4665 (#4666)
  Update Volto contributing to align with and refer to the new Plone co… (#4634)
  Release @plone/scripts 3.0.0
  Changelog
  Added querystring search get option (#4658)
  Add current page parameter to the route in the listing and search block pagination (#4159)
  Fixed wrong localization on password reset page(#4656) (#4657)
  Release notes for 16.19.0 (#4655)
  Razzle upgrade notice in upgrade guide (#4641)
  Release generate-volto 7.0.0-alpha.3
  Update to latest Razzle - needed since #3997. This fixes the duplicated Razzles issue (#4640)
  3092 improve spellcheck (#4633)
  developer process for first time contributing (#4617)
  Trigger CI on pull_request event (#4629)
  Pining of `pydata-sphinx-theme` and `sphinx-book-theme`, CI is complaining. (#4626)
  Set sameSite in `18N_LANGUAGE` cookie (#4627)
  Update simple-git (#4546)
  DefaultView (blocks disabled): Show field name as tip on hover of label (#4598)
  Fix regexp that checks valid URLs and improve tests (#4601)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants