issue-5452 markdown shortcut #5495
Conversation
✅ Deploy Preview for volto canceled.
|
kHAPPY2004
force-pushed
the
issue5452-markupShortcuts-fix
branch
from
1f4b0f9
to
7d87e01
Compare
|
@kHAPPY2004 do not open and close multiple pull requests for the same issue. See item 3: https://6.docs.plone.org/contributing/first-time.html#things-not-to-do |
| @@ -0,0 +1 @@ | |||
| Fixed markup shortcut for heading and blockquote @kHAPPY2004 | |||
There was a problem hiding this comment.
What exactly was broken, and how was it fixed? Please include some details, such as what was the original broken behavior and what is the new fixed behavior. These change log entries appear in documentation upon release, so they should be helpful to a developer looking to fix a broken behavior that they observed.
|
Hi @stevepiercy, sorry for making multiple pull request. I have improved the changelog, please verify and let me know if i have done it correctly this time. |
Co-authored-by: Steve Piercy <web@stevepiercy.com>
…rtcuts-fix' into issue5452-markupShortcuts-fix
stevepiercy
requested review from
tiberiuichim,
sneridagh,
nileshgulia1 and
razvanMiu
|
@kHAPPY2004 are you familiar with Cypress tests? Do you imagine to create one for the fix (and for other markdown feature)? |
|
@kHAPPY2004 more information about Cypress, which Volto uses for Acceptance testing. |
@sneridagh No I am not familiar with cypress yet... |
✅ Deploy Preview for plone-components canceled.
|
stevepiercy
changed the title
|
@sneridagh If this works and I assume it works since Tiberiu and Razvan accepted the work I think we can live with merging this fix without having a test in order to get this over with. |
* main: Make dynamic/live teaser without additional requests (#6024) Fix issue of duplicated blocks upon pasting an image into the Slate E… (#5818) Remove `api` folder. Add `backend` folder using latest backend best practices (#6110) Rename files with wrong extension `js->jsx` when they contain JSX. (#6114) Improve shadowing by including the support for `js->jsx` extensions in… (#6113) issue-5452 markdown shortcut (#5495)
* main: Make dynamic/live teaser without additional requests (#6024) Fix issue of duplicated blocks upon pasting an image into the Slate E… (#5818) Remove `api` folder. Add `backend` folder using latest backend best practices (#6110) Rename files with wrong extension `js->jsx` when they contain JSX. (#6114) Improve shadowing by including the support for `js->jsx` extensions in… (#6113) issue-5452 markdown shortcut (#5495)
* main: (73 commits) Release 18.0.0-alpha.36 Rename missing command Image widget PR as breaking (#6125) Release @plone/slate 18.0.0-alpha.14 Release @plone/registry 1.7.0 Rename Makefile targets (#6104) fix: nonContentRoutes diff path (#6102) Automatically set the label to `03 type: feature (plip)` for PLIPs (#6122) Add ImageWidget with upload/drop/external and inline/widget capabilities (#5607) Ensure that sidebar field will not steal focus when metadata is edited (#5983) Prevent duplicated UUUIDs in inner blocks when copying container blocks (#6112) feat: handle breakList in detached TextBlockEditor (#6106) Make dynamic/live teaser without additional requests (#6024) Fix issue of duplicated blocks upon pasting an image into the Slate E… (#5818) Remove `api` folder. Add `backend` folder using latest backend best practices (#6110) Rename files with wrong extension `js->jsx` when they contain JSX. (#6114) Improve shadowing by including the support for `js->jsx` extensions in… (#6113) issue-5452 markdown shortcut (#5495) Release 18.0.0-alpha.35 Release @plone/types 1.0.0-alpha.16 ...
Co-authored-by: Steve Piercy <web@stevepiercy.com> Co-authored-by: Víctor Fernández de Alba <sneridagh@gmail.com> Co-authored-by: ichim-david <ichim.david@gmail.com>
Fixes #5452
Fixes automarkup shortcut bug for heading and blockquote