-
Notifications
You must be signed in to change notification settings - Fork 102
Handle properties that can be either single or multiple values #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Example of what is now possible: let crazyMarker =
Marker.init(
MultiSymbols = [
StyleParam.MarkerSymbol.ArrowBarDown
StyleParam.MarkerSymbol.Modified(StyleParam.MarkerSymbol.DiamondCross, StyleParam.SymbolStyle.OpenDot)
StyleParam.MarkerSymbol.Modified(StyleParam.MarkerSymbol.Square, StyleParam.SymbolStyle.Open)
StyleParam.MarkerSymbol.Modified(StyleParam.MarkerSymbol.Hexagon2, StyleParam.SymbolStyle.Dot)
],
MultiSizes = [50;60;100;70],
MultiOpacities = [0.3; 0.6; 0.9; 1.],
Color = Color.fromColorScaleValues [0.; 0.5; 1.; 0.8],
Colorscale = StyleParam.Colorscale.Viridis,
ShowScale = true
)
Chart.Point [1,1; 2,2; 3,3; 4,4]
|> Chart.withMarker crazyMarker
|> Chart.show |
eedfe35 to
f226e95
Compare
…thMarkerStyle overriding exisitng markers
Collaborator
Author
|
More goodness: let labels, values =
[
"A", 1
"B", 3
"C", 2
"D", 4
"E", 6
"F", 5
"G", 7
"H", 8
]
|> List.unzip
Chart.Bar(
keys = labels,
values = values,
Color = Color.fromColorScaleValues values
)
|> Chart.withMarkerStyle(
Colorscale = StyleParam.Colorscale.Viridis,
ShowScale = true,
Pattern = Pattern.init(
MultiShapes = [
StyleParam.PatternShape.None
StyleParam.PatternShape.DiagonalDescending
StyleParam.PatternShape.DiagonalAscending
StyleParam.PatternShape.DiagonalChecked
StyleParam.PatternShape.HorizontalLines
StyleParam.PatternShape.VerticalLines
StyleParam.PatternShape.Checked
StyleParam.PatternShape.Dots
]
)
)
|> Chart.show |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


This PR adds internal utils to set properties that can be either set by a single value or an array of values on the plotly.js side. We do not use a DU for this because it would increase verbosity too much. See #192
I also implemented this for bar traces and the Marker object (where this was most requested) for reference. Implementing this for all traces/charts is a huge chunk of work and may be too much to do before 2.0 release. Progress is tracked in #196
fixes #191