StaticImageExport: Allow to use a local browser, instead of BrowserFetcher #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd avoid downloading if a local path is given.
Collaborator
|
Thank you, this makes a lot of sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current implementation, there is always the
BrowserFetchercalled when exporting an image.This is a problem when the library is used e.g. in some environment with limited access to the Internet, because chromium is downloaded at least once.
I added an option to set a
localBrowserExecutablePathin thePuppeteerSharpRendererOptions.If that options set,
fetchAndLaunchBrowserAsyncuses that path. Otherwise it calls theBrowserFetcherand and does the already known stuff.