Skip to content

Manage NPM packages properly #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Manage NPM packages properly #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,17 @@ jobs:
source .venv/bin/activate
npm run build
shell: bash
- name: Generate distribution
- name: Generate Python distribution
run: |
source .venv/bin/activate
npm run dist
npm pack && mv *.tgz dist/
shell: bash
- name: Build npm package
run: |
source .venv/bin/activate
npm pack
mkdir -p npm-dist
mv *.tgz npm-dist/
shell: bash
- name: Validate distribution
run: |
Expand All @@ -50,8 +56,14 @@ jobs:
uv pip install "${WHL_FILE}[dev]"
npm run test
shell: bash
- name: Upload built distributions
- name: Upload Python distributions
uses: actions/upload-artifact@v4
with:
name: package-distributions
name: python-distributions
path: dist/

- name: Upload npm package
uses: actions/upload-artifact@v4
with:
name: npm-package
path: npm-dist/
18 changes: 15 additions & 3 deletions .github/workflows/publish-to-pypi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,24 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Download built distributions
- name: Download Python distributions
uses: actions/download-artifact@v4
with:
name: package-distributions
name: python-distributions
path: dist/
- name: Publish package distributions to PyPI
uses: pypa/gh-action-pypi-publish@release/v1
with:
password: ${{ secrets.PYPI_API_TOKEN }}
password: ${{ secrets.PYPI_API_TOKEN }}

- name: Download npm package
uses: actions/download-artifact@v4
with:
name: npm-package
path: npm-dist/
- name: Publish to npm
run: |
npm publish npm-dist/*.tgz --access public
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
shell: bash
13 changes: 9 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,18 @@ jobs:
steps:
- name: Checkout repo
uses: actions/checkout@v4
- name: Download built distributions
- name: Download Python distributions
uses: actions/download-artifact@v4
with:
name: package-distributions
name: python-distributions
path: dist/
- name: Download npm package
uses: actions/download-artifact@v4
with:
name: npm-package
path: npm-dist/
- name: Upload GitHub Release
uses: ncipollo/release-action@v1
with:
artifacts: "dist/*.whl,dist/*.tar.gz"
draft: true
artifacts: "dist/*.whl,dist/*.tar.gz,npm-dist/*.tgz"
draft: true