Speck system fix #312
Speck system fix #312
Conversation
This reverts commit b90c0f9.
|
The previous deployments were failing due to #313. I've added a temporary fix by locking the Dash version to |
CHANGELOG.md
Outdated
| figure. | ||
| * Fixed issue with Speck not rendering unless it is attached to a callback. | ||
| * Fixed issue with Speck trying to calculate a system with no atoms, | ||
| which led to an error. |
There was a problem hiding this comment.
I suggest removing this line.
There was a problem hiding this comment.
@mkcor This is an issue that was fixed, though -- do you have an idea of how it could be worded better? (Or does this belong in another section?)
There was a problem hiding this comment.
My rewording suggestion corresponds to making the whole sentence fit in one line, which is "Prevent Speck from trying to calculate a system with no atom." It says it all. We fixed an issue (when there was an issue, there was an error, but it's trivial so there's no need to specify it; it's not surprising that trying to calculate an empty system would lead to an error; it's not interesting to write out "there used to be an error" and the source code is clear and commented...).
"Prevent Speck from trying to calculate a system with no atom" makes it clear that previously Speck was trying to calculate such a system and clearly that was an issue!!
There was a problem hiding this comment.
Thanks for the clarification :) Fixed in 8a1f343!
Small wording/spelling fixes. Co-Authored-By: shammamah <shammamah.hossain@gmail.com>
Description of changes
Previously, the Speck component was trying to calculate the radius for an atom even if no atoms were present in the system. This led to an exception and a failure to render.
Now, the function
loadStructuresimply returns if there are no atoms supplied in the system and consequently avoids this error.I also fixed the CHANGELOG to have nicer formatting and added the fix from #311 to the notes for the 0.0.9 release.
Before merging