[MRG] Phylogeny Example review #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhluca
requested review from
NadiaTahiri,
chriddyp,
jackluo,
mtwichan and
nchtra
Author
|
Thank you! |
mtwichan
previously requested changes
Nov 29, 2018
mtwichan
left a comment
mtwichan
left a comment
There was a problem hiding this comment.
When using the application, I had some issues with zooming in/out with the wheel. The graph disappeared for me, or I zoomed out to far and lost the graph. I think adding a button to reset the graph to it's original position may be a good idea, or something along the lines of that.
Application: https://dash-gallery.plotly.host/cytoscape-phylogeny
Author
|
Thanks for the review. I'll update it in: https://github.com/xhlulu/cytoscape-phylogeny |
xhluca
dismissed
mtwichan’s stale review
Talked with Matthew, will add this request in the relevant repo
Contributor
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will review the phylogeny demo app.
Please visualize the app here: https://dash-gallery.plotly.host/cytoscape-phylogeny
The link is not synchronized with this PR, so if i update this it won't show up on the app