Skip to content

Conversation

@xhluca
Copy link

@xhluca xhluca commented Jan 19, 2019

This will be squashed and merged

Copy link
Contributor

@shammamah-zz shammamah-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💃


### Fixed
* Console error where `setProps` gets called even when it is undefined (# 28)
* Incorrect setProps assignment that causes `setProps` to not be properly defined when nested in bigger apps (e.g. `dash-docs`) (#28)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for fixing this! 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@xhluca xhluca merged commit c8b70ca into master Jan 22, 2019
@xhluca xhluca deleted the v0.0.4 branch February 7, 2019 15:13
@xhluca
Copy link
Author

xhluca commented Feb 12, 2019

Fixes #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants