Add unit tests, setup CircleCI and Percy #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 27, 2019 23:22
Needed to auto-generate screenshots from test_usage.py, which will be then used in test_percy_snapshot for CVI
To be broken down into different tests
Almost exhaustive test of many different types of apps, from the usage apps in root to the demos
Create a single app that generate a webpage containing all the screenshots taken in the test_usage.py. We then take a screenshot of everything using percy, and this is used to compare differences. We employ this method because it is currently impossible for percy to render canvas elements (since it directly crawls the DOM), so this is the only way to proceed
Author
Member
|
I just enabled percy for this repo, so the status should appear in the PR's "checks" in the future. |
Member
|
In general, it'd be good to do separate snapshots for each chart rather than one large snapshot. That way, if one of the images changes, it won't impact the diff of the other images (e.g. if the first graph changes height, then it'll effect the rest of the page) |
chriddyp
reviewed
Feb 28, 2019
chriddyp
reviewed
Feb 28, 2019
chriddyp
reviewed
Feb 28, 2019
chriddyp
reviewed
Feb 28, 2019
chriddyp
requested changes
Feb 28, 2019
Member
chriddyp
left a comment
chriddyp
left a comment
There was a problem hiding this comment.
Looks good, this was a clever solution. Just a few small suggestions on my end.
xhluca
commented
Feb 28, 2019
| return "data:image/png;base64," + encoded_string.decode('ascii') | ||
|
|
||
| # Define the app | ||
| app = dash.Dash(__name__) |
Author
There was a problem hiding this comment.
@chriddyp check out this multi-route app. Here I Assign the url path to return the image it represent. For example, to return "usage.png", you can visit localhost/usage.png.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
CircleCI builds: https://circleci.com/gh/xhlulu/dash-cytoscape/tree/master
Percy build: https://percy.io/plotly/dash-cytoscape
Please note that I have already setup CircleCI on the Plotly account, I'm simply using my personal account so I can work on the PR directly while testing changes in the build. The (currently unused) build is here: https://circleci.com/gh/plotly/dash-cytoscape
Description of changes
With this PR, we will introduce 2 new test classes, namely
test_usageandtest_percy_snapshot. The former will run most of the usage apps, then save a screenshot of each.test_percy_snapshotwill then create an app containing all of those images, and take a screenshot for continuous visual integration.This PR will also update the
config.ymlin order to accomodate the new tests, as well as include tests for Python 3.7. I decided not to add support for 2.7 because of the imminent deprecation.Pre-Merge checklist
npm run build:all.Reference Issues
Closes #[issue number]
Other comments