Skip to content

Conversation

@xhluca
Copy link

@xhluca xhluca commented Mar 4, 2019

About

Percy: https://percy.io/plotly/dash-cytoscape
CircleCI: https://circleci.com/gh/plotly/dash-cytoscape

Description of changes

Callback tests: tests.test_callbacks
Interaction tests: tests.test_interactions

The callback tests are broken down into 3 categories: layout, elements, style. They are written in all caps on the percy builds.

Pre-Merge checklist

  • The project was correctly built with npm run build:all.
  • If there was any conflict, it was solved correctly
  • All changes were documented in CHANGELOG.md.
  • All tests on CircleCI have passed.
  • All Percy visual changes have been approved.
  • Two people have 💃'd the pull request. You can be one of these people if you are a Dash Cytoscape core contributor.

Reference Issues

Closes #[issue number]

Other comments

@xhluca xhluca requested review from chriddyp and shammamah-zz March 4, 2019 23:15
Additionally, changes to the Python versioning avoids version errors
with CircleCI, as discussed here:
plotly/dash#636
@xhluca
Copy link
Author

xhluca commented Mar 8, 2019

Copy link
Member

@chriddyp chriddyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 💃 💃 💃 💃 💃

@xhluca xhluca merged commit 26df79a into master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants