Add 2 new demos, reoganize README, update Cytoscape wrapper default values and docstring #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 31, 2019 15:57
shammamah-zz
reviewed
Apr 2, 2019
Contributor
shammamah-zz
left a comment
shammamah-zz
left a comment
There was a problem hiding this comment.
Awesome job, Xing! Cytoscape is getting better and better 👍
dash_cytoscape/Cytoscape.py
Outdated
| default (if true, overrides individual element state). | ||
| - autoRefreshLayout (boolean; optional): Whether the layout should be refreshed when elements are added or removed. | ||
| - tapNode (dict; optional): The complete node dictionary returned when you tap or click it. | ||
| - tapNode (dict; optional): The complete node dictionary returned when you tap or click it. Cannot be modified by a |
Contributor
There was a problem hiding this comment.
Maybe say that it's "read-only" instead -- that might be clearer!
demos/usage-preset-animation.py
Outdated
| 'animate': True, | ||
| 'animationDuration': 1000, | ||
| 'positions': { | ||
| node_id: {'x': 20 * lat, 'y': -20 * long} |
Contributor
There was a problem hiding this comment.
long here appears to be a keyword, since it refers to a data type -- you could maybe consider changing it to avoid confusion (and problems with syntax highlighting, as we see here).
Co-Authored-By: xhlulu <xhlperso@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Description of changes
Pre-Merge checklist
npm run build:all.Reference Issues
Other comments