Create demos for R #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpkyle
force-pushed
the
create-dashr-demos
branch
from
7750203 to
5a636ff
Compare
Contributor
|
I've removed the example which was unfinished (for now), and have edited out the very soon-to-be deprecated references to core component packages; I'll merge this into the v0.3.0 branch. |
rpkyle
requested review from
Marc-Andre-Rivet,
alexcjohnson and
xhluca
as code owners
rpkyle
force-pushed
the
create-dashr-demos
branch
from
9d66dc6 to
6df310c
Compare
Contributor
|
Thanks again @ohaanika 🙃 |
demosR/phylogeny/dummyData.R
Outdated
| @@ -0,0 +1,248 @@ | |||
| dummyNodes <- list( | |||
There was a problem hiding this comment.
Do the contents of /demosR/phylogeny serve any purpose?
I can't find any reason for them to be there, they don't affect the examples as far as I can tell.
🔪
Contributor
There was a problem hiding this comment.
good catch -- I removed that demo (for now) because it was unfinished, will clean up this directory also.
Co-authored-by: HammadTheOne <30986043+HammadTheOne@users.noreply.github.com>
xhluca
pushed a commit
that referenced
this pull request
Jun 21, 2021
* chore: use build:backends * chore: update R package to v0.3.0 * chore: update CHANGELOG.md * Create demos for R (#68) Co-authored-by: Aanika Rahman <aanika.rahman@mail.mcgill.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo Checklist
Creating the R equivalent of the demos in the main directory of the repo:
Creating the R equivalent of the demos working correctly in Python:
Creating the R equivalent of the demons that are not fully functional yet in Python or are a WIP:
About
Description of changes
Pre-Merge checklist
npm run build:all.Reference Issues
Closes #[issue number]
Other comments