Skip to content

Conversation

@rpkyle
Copy link
Contributor

@rpkyle rpkyle commented Aug 1, 2020

This PR proposes to contribute the initial build of the dashPivottable package for R. In addition, edits are suggested to package.json to populate fields in the R package metadata, and to the docstring within PivotTable.react.js (since CRAN requires descriptions for package functions).

The tips dataset used in Python has been imported into R, and is now stored within the package as .RData. The R examples are embedded within dash-info.yaml so that they are accessible from within R's online help.

@rpkyle rpkyle requested a review from xhluca August 1, 2020 14:15
@rpkyle rpkyle self-assigned this Aug 1, 2020
@xhluca
Copy link

xhluca commented Aug 2, 2020

I don't know R well, so I'm trusting you on this :) Maybe we should release this as a v0.0.2 since we are modifying PivotTable.py?

@rpkyle
Copy link
Contributor Author

rpkyle commented Aug 2, 2020

I don't know R well, so I'm trusting you on this :) Maybe we should release this as a v0.0.2 since we are modifying PivotTable.py?

Sounds good, I'll make the changes prior to merging and update the CHANGELOG.md accordingly.

@rpkyle rpkyle changed the title Build dashPivottable v0.0.1 for Dash for R Build dashPivottable v0.0.2 for Dash for R Aug 4, 2020
@rpkyle rpkyle merged commit 13b3d4c into master Aug 4, 2020
@rpkyle rpkyle deleted the add-r-package branch August 4, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants