Skip to content

Fix loading selector with children starting at the same digit #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

Fix loading selector with children starting at the same digit #3278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c12b542
Fix loading selector with children starting at the same digit
T4rk1n Apr 15, 2025
fe78a05
Update changelog
T4rk1n Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
All notable changes to `dash` will be documented in this file.
This project adheres to [Semantic Versioning](https://semver.org/).

## [UNRELEASED]

## Fixed
- [#3278](https://github.com/plotly/dash/pull/3278) Fix loading selector with children starting at the same digit. Fix [#3276](https://github.com/plotly/dash/issues/3276)

## [3.0.3] - 2025-04-14

## Fixed
Expand Down
5 changes: 3 additions & 2 deletions components/dash-core-components/src/components/Loading.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,9 @@ const coveringSpinner = {

const loadingSelector = (componentPath, targetComponents) => state => {
let stringPath = JSON.stringify(componentPath);
// Remove the last ] for easy match
stringPath = stringPath.substring(0, stringPath.length - 1);
// Remove the last ] for easy match and add `,` to make sure only children
// trigger the loading. See issue: https://github.com/plotly/dash/issues/3276
stringPath = stringPath.substring(0, stringPath.length - 1) + ',';
const loadingChildren = toPairs(state.loading).reduce(
(acc, [path, load]) => {
if (path.startsWith(stringPath) && load.length) {
Expand Down